Don't use the custom 'Template Parts' page with WP 6.1 and above #45158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
fabiankaegy
and removed request for
spacedmonkey
Mamaduka
force-pushed
the
add/check-for-template-parts-screen
branch
from
5b27479 to
229cb23
Compare
fabiankaegy
reviewed
Oct 21, 2022
|
|
||
| $needs_custom_page = true; | ||
| foreach ( $submenu['themes.php'] as $menu_item ) { | ||
| if ( str_contains( $menu_item[2], 'site-editor.php?postType=wp_template_part' ) ) { |
There was a problem hiding this comment.
I'm not sure whether there is any other way to query this, but just from my gut feeling this feels rather fragile. But I will still approve the PR since we can follow up with a more robust solution and this does fix the bug that is currently present.
fabiankaegy
approved these changes
Oct 21, 2022
Mamaduka
added
the
Backport to Gutenberg RC
|
@priethor, @juanmaguitar, can we backport this into 14.4? It would be great to land the fix in the plugin before WP 6.1 is released |
priethor
pushed a commit
that referenced
this pull request
Oct 24, 2022
priethor
removed
the
Backport to Gutenberg RC
|
Cherry-picked to the 14.4 branch in 55180ae ✅ |
|
Thank you, @priethor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR adds a check not to register the custom 'Template Parts' page for WP 6.1 and above. This also prevents displaying two menu items with 'Template Parts' under the Appearance.
Why?
The custom page is only needed for older WP versions, where required restrictions are missing from
site-editor.php.Testing Instructions
site-editor.phppath.Screenshots or screencast