Post comment count: Add spacing support #45150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Type] Enhancement
carolinan
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
carolinan
changed the title
aristath
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Works as expected.
Thank you for working on these @carolinan! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds margin and padding to the post comment count block.
Why?
For consistency.
How?
Testing Instructions
This block is only available in the site editor so you need to activate a block theme.
Make sure that the active theme supports spacing, for example in theme.json.
The block is easiest to test inside a query loop and post template, otherwise it will display a placeholder message.
In the site editor, locate or add a query loop.
Inside the post template, add the post comment count block.
Confirm that there is a dimension panel, and that the margin and and padding settings are available but not enabled by default.
Test the margin and padding settings in the editor and front.
Screenshots or screencast