-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments: Add spacing support #45102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Type] Enhancement
A suggestion for improvement.
[Block] Comments
Affects the Comments Block - formerly known as Comments Query Loop
labels
Oct 19, 2022
Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
carolinan
requested review from
michalczaplinski,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
October 19, 2022 09:35
Size Change: +49 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Comments
Affects the Comments Block - formerly known as Comments Query Loop
Needs User Documentation
Needs new user documentation
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add padding and margin support to the comments block.
Why?
For consistency.
How?
Testing Instructions
Create a new post or page and add a comments block.
Confirm that there is a dimension panel and that padding and margin are available but not enabled by default.
Test the padding and margin settings and confirm if the settings work, both in the editor and the front (optionally, add a background color for better visibility).
Screenshots or screencast