ESLint: Fix testing-library/no-render-in-setup violations
#45097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
tyxla
requested review from
Mamaduka,
mirka,
jsnajdr,
ciampo,
chad1008 and
ntsekouras
|
|
Mamaduka
reviewed
Oct 19, 2022
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Thank you, @tyxla!
I personally prefer inlining, but it would be great to hear feedback from others as well.
P.S. I think this rule was inspired by the Avoid Nesting when you're Testing post.
ciampo
reviewed
Oct 19, 2022
|
|
||
| test( 'should render correctly', () => { | ||
| renderVisibleTooltip(); |
There was a problem hiding this comment.
Nitty, but I usually prefer to have the render call inlined into each test for better readability (and in case we needed to grab anything from return value of the render call).
Maybe we could extract a VisibleTooltip React component, and then refactor each test to:
render( <VisibleTooltip /> );
@Mamaduka , is that also what you were referring to?
There was a problem hiding this comment.
Correct, and I like your suggestion of extracting this into a new component on the test module level.
There was a problem hiding this comment.
That sounds like an improvement, I'm happy to follow-up with this.
There was a problem hiding this comment.
Suggested in #45105. Thanks for the feedback, both 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes all violations of the
testing-library/no-render-in-setuprule, in preparation for enablingeslint-plugin-testing-libraryglobally for the project.See the plugin README for more info on the
testing-libraryESLint plugin.Why?
We've been improving our tests a lot recently with the migration to
@testing-library. One way we could improve them is to better standardize them and follow best practices whenever we can, and one of the best ways to get there is to follow the recommended ESLint rules of the libraries and utilities we use under the hood.How?
We're moving the rendering to the actual tests.
Testing Instructions
Verify all checks are green.
cc @brookewp as we've been discussing working to address some of those violations together.