List/quote: unwrap inner block when pressing Backspace at start #45075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Feature] Writing Flow
|
Size Change: +111 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
mcsf
reviewed
Oct 18, 2022
There was a problem hiding this comment.
In terms of writing flow, I really like this!
My immediate instinct with isUnmodifiedBlock was whether we need a new API, but also whether we could do without that kind of special handling in the merger, and just consider whether the block is empty — not sure.
Anyway, that got me to test this with empty blocks, and I found the following bug:
- Insert a Paragraph followed by a List with a couple of List Items
- Move the caret to the beginning of the first List Item
- Press Enter to insert an empty List Item
- Move the caret up to that empty item
- Press Backspace
Unexpected: the whole List is deleted.
Screen.Recording.2022-10-18.at.16.42.06.mov
That would be the same as |
alexstine
reviewed
Oct 19, 2022
There was a problem hiding this comment.
@ellatrix I think it would be cool to sneak an A11Y improvement in to this PR. As far as functionality goes, it works fine. However, it would be great to have additional context that tells screen reader users what just happened.
Combined content from list block in to previous paragraph block. Deleted list block. Now editing paragraph block.
Deleted list block. Now editing previous paragraph block.
Thoughts on how to communicate this information?
mcsf
reviewed
Oct 19, 2022
Comment on lines
+85
to
+87
| expect( await hasBlockSwitcher() ).toBeFalsy(); | ||
| // Verify the correct block transforms appear. | ||
| expect( await getAvailableBlockTransforms() ).toHaveLength( 1 ); | ||
| expect( await getAvailableBlockTransforms() ).toHaveLength( 0 ); |
There was a problem hiding this comment.
The comments in this test no longer seem to agree with the code. Where is the change coming from?
There was a problem hiding this comment.
The comments should actually make sense because I'm merely reverting
https://github.com/WordPress/gutenberg/pull/43181/files#diff-56243bd4e7ab153498f10d75b0827121efa47fe088f53d75332a093e91a7edf2
Comment on lines
-117
to
-127
| { | ||
| type: 'block', | ||
| blocks: [ '*' ], | ||
| transform: ( _attributes, childBlocks ) => { | ||
| return getListContentFlat( childBlocks ).map( ( content ) => | ||
| createBlock( 'core/paragraph', { | ||
| content, | ||
| } ) | ||
| ); | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Checking my assumptions here: this bit that we removed — i.e. the Unwrap transform — was functionally equivalent to the Transform to Paragraph transform, right? So we don't lose anything?
There was a problem hiding this comment.
Yes, it was a hackier way of doing list item to paragraph. It wasn't great because '*' should mean unwrap, while this is unwrapping and converting it to paragraphs.
| } = registry.select( blockEditorStore ); | ||
|
|
||
| function moveFirstItemUp( _clientId, changeSelection = true ) { |
There was a problem hiding this comment.
A high-level comment stating the goal of the function and its general algorithm would be greatly appreciated. :)
ellatrix
force-pushed
the
try/list-quote-merge-gradually
branch
from
7f26426
to
fd3944b
Compare
ellatrix
commented
Nov 25, 2022
| await pageUtils.pressKeyTimes( 'ArrowUp', 3 ); | ||
| await page.keyboard.press( 'Delete' ); | ||
|
|
||
| expect( await editor.getEditedPostContent() ).toMatchSnapshot(); |
There was a problem hiding this comment.
Restored tests to pre #44916
Mamaduka
reviewed
Nov 25, 2022
...-blocks-test-restore-sele-2a1ee-roduces-more-than-one-block-on-forward-delete-1-chromium.txt
Show resolved
Hide resolved
ellatrix
force-pushed
the
try/list-quote-merge-gradually
branch
from
649e78e
to
e1b346d
Compare
geriux
approved these changes
Nov 30, 2022
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
This was referenced Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #34100.
Follow up to #43181.
Why?
It's less jarring than the current experience: unwrapping all list items at once.
How?
Modifies the onMerge function.
Testing Instructions
Create a list, press Backspace at the start of the first list item.
Do the same for Quote and Group.
Screenshots or screencast