ESLint: Add and enable eslint-plugin-jest-dom
#44983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Build Tooling
tyxla
requested review from
Mamaduka,
youknowriad,
mirka,
jsnajdr,
gziolo,
ciampo,
chad1008,
ntsekouras and
a team
ciampo
reviewed
Oct 14, 2022
| const invisibleTooltipTrigger = screen.getByText( | ||
| invisibleTooltipTriggerContent | ||
| ); | ||
| // The invisible tooltip should not render. | ||
| expect( tooltips ).toHaveLength( 1 ); | ||
| // The base tooltip should render only; invisible tooltip should not render. |
There was a problem hiding this comment.
Nit — I'm not sure I understand this inline comment!
There was a problem hiding this comment.
For some reason in the original test, the "WordPress.org - Invisible" text is referred to as "invisible tooltip". I've just kept that reference. But I'm happy to improve it if you have an idea why we were referring to it as "invisible tooltip" in the first place!
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Oct 14, 2022
|
Thanks for the feedback here and in the related PR, everyone! I'm shipping this one, and I'm happy to disable some rules in the future if we end up considering them too restrictive. However, I do believe they are pretty straightforward and I don't see that likely to happen. |
|
Nice work, @tyxla 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR introduces the
eslint-plugin-jest-domESLint plugin and enables it for all non-native test files.Why?
It aims to help maintain following the best practices when writing tests with
jest-dom. There's been a discussion around how restrictive those are, and I believe they ensure best practices while being not-so-restrictive, but I'm happy to take feedback.How?
We're enabling the plugin and all its recommended rules for all test files, and excluding all native tests because there's a separate library for it, and we're not using it just yet.
We're also fixing a false positive in a test - the only remaining one that wasn't following the recommended rules.
Testing Instructions
element.textContentorelement.getAttribute()in your test, you'll get an error.