Rename header and sidebar components in edit-site #44974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Feature] Site Editor
youknowriad
commented
Oct 14, 2022
| @@ -144,32 +134,14 @@ body.is-navigation-sidebar-open { | |||
| } | |||
| } | |||
|
|
|||
| .edit-site-header__actions-more-menu { | |||
There was a problem hiding this comment.
This was dead code
youknowriad
requested review from
ntwb,
nerrad,
ajitbohra and
ellatrix
as code owners
|
Size Change: +28 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
| @@ -32,7 +32,6 @@ $z-layers: ( | |||
| ".edit-post-layout__footer": 30, | |||
| ".interface-interface-skeleton__header": 30, | |||
| ".interface-interface-skeleton__content": 20, | |||
| ".edit-site-header": 62, | |||
There was a problem hiding this comment.
It seems these z-index layers were not being used even before this PR. It would be nice to have something that detects this.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #44770
What?
The header and sidebar components will correspond to headers and sidebars for the editor mode only. This PR renames the folders to ensure that the diff in #44770 becomes clearer. The current PR doesn't do anything aside renaming components and classnames.