Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: typo in block.json schema default scope values #44944

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

jeremylind
Copy link
Contributor

The accepted scope value is inserter, not inseter

What?

Fixing a typo

Why?

Use an accepted default value for scope.

How?

Fixes the typo.

Testing Instructions

While editing in a text editor that uses $schema context, add a scope attribute to a variation.

Screenshots or screencast

The accepted scope value is `inserter`, not `inseter`
@jeremylind jeremylind requested a review from ajlende as a code owner October 13, 2022 16:43
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 13, 2022
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jeremylind! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Copy link
Contributor

@ajlende ajlende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! 👍

@ajlende ajlende changed the title FIX: typo in default scope values FIX: typo in block.json schema default scope values Oct 13, 2022
@ajlende ajlende merged commit 653920f into WordPress:trunk Oct 13, 2022
@github-actions
Copy link

Congratulations on your first merged pull request, @jeremylind! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 14.4 milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants