Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the names of filters for global styles data #44940

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Update the names of filters for global styles data #44940

merged 2 commits into from
Oct 14, 2022

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Oct 13, 2022 •
edited
Loading

Backports changes made in wordpress-develop at WordPress/wordpress-develop#3443 related to filters for global styles data.

It does not backport the changes done to the theme_json_get_style_nodes filter. This needs to be considered separately (see).

Changes:

  • updates block editor handbook docs
  • names of filters

@oandregal oandregal mentioned this pull request Oct 13, 2022
Closed
@oandregal oandregal self-assigned this Oct 13, 2022
@oandregal oandregal added the Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core label Oct 13, 2022
SergeyBiryukov
SergeyBiryukov approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@SergeyBiryukov SergeyBiryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on these last-minute changes in core 😅 Looks good to me 👍

@ajlende ajlende mentioned this pull request Oct 13, 2022
Merged
@oandregal oandregal merged commit 050e95c into trunk Oct 14, 2022
@oandregal oandregal deleted the update/names-filters-gs branch October 14, 2022 09:56
@github-actions github-actions bot added this to the Gutenberg 14.4 milestone Oct 14, 2022
@mmtr mmtr mentioned this pull request Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyBiryukov SergeyBiryukov SergeyBiryukov approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@hellofromtonya hellofromtonya Awaiting requested review from hellofromtonya

@ocean90 ocean90 Awaiting requested review from ocean90

Assignees

@oandregal oandregal

Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core
Projects
None yet
Milestone
Gutenberg 14.4
Development

Successfully merging this pull request may close these issues.
2 participants
@oandregal @SergeyBiryukov