Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .eslintcache to .gitignore #44938

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Add .eslintcache to .gitignore #44938

merged 1 commit into from
Oct 13, 2022

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Oct 13, 2022

What?

This PR adds .eslintcache to .gitignore.

Why?

Necessary when using eslint-nibble locally with the --cache option.

How?

We're straightforwardly git-ignoring that file.

Testing Instructions

Not necessary, but you can run npx eslint-nibble ./ --cache --fixable-only and you'll see such a file be created locally.

@tyxla tyxla added [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Build Tooling Issues or PRs related to build tooling labels Oct 13, 2022
@tyxla tyxla requested a review from a team October 13, 2022 12:56
@tyxla tyxla self-assigned this Oct 13, 2022
@tyxla tyxla requested review from mcsf, Mamaduka and ciampo and removed request for a team October 13, 2022 12:56
Mamaduka
Mamaduka approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@tyxla tyxla merged commit 8f00bd0 into trunk Oct 13, 2022
@tyxla tyxla deleted the add/gitignore-eslintcache branch October 13, 2022 13:46
@github-actions github-actions bot added this to the Gutenberg 14.4 milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@mcsf mcsf Awaiting requested review from mcsf mcsf was automatically assigned from WordPress/gutenberg-core

@ciampo ciampo Awaiting requested review from ciampo

Assignees

@tyxla tyxla

Labels
[Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
Gutenberg 14.4
Development

Successfully merging this pull request may close these issues.
2 participants
@tyxla @Mamaduka