Ensure stale github actions workflow only runs for particular issue labels #44910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
the
[Type] Project Management
talldan
commented
Oct 13, 2022
| stale-issue-message: ${{ matrix.message }} | ||
| days-before-stale: ${{ matrix.days-before-stale }} | ||
| days-before-close: ${{ matrix.days-before-close }} | ||
| only-labels: ${{ matrix.only-labels }} |
There was a problem hiding this comment.
From what I understand, an unset value is ok - https://github.com/actions/stale#only-labels:
If unset (or an empty string), this option will not alter the stale workflow.
andrewserong
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Looks worth trying to me! From a quick 👀 at #44754, it seems that matrix.only-labels should contain the desired value, and only-labels is the right place for it to be assigned to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A bug was introduced in #44754, whereby stale workflows that are supposed to run for issues with particular labels were run on all issues.
This PR remedies the problem.
I guess we'll have to find a way to go back through all the issues that 'Stale' was accidentally applied to and remove the labels. Maybe a script that removes every stale label added in the last 24 hours?
How?
Ensures the
only-labelsproperty is set.Looks like some automatic formatting was also applied to the yml file 🤔
Testing Instructions
There is no way to test it, we'll just have to wait and see 😎