Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry Pick Script: Restore retrieval of merge_commit_sha #44890

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Cherry Pick Script: Restore retrieval of merge_commit_sha #44890

merged 1 commit into from
Oct 12, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

What?

Fixes regression introduced by #44662

Why?

Without the fix, it fails when attempting to retrieve commit hashes.

How?

Destructures the merge_commit_sha property from the fetched GitHub PR data in a way that still keeps the linter happy honouring the intent of #44662

Testing Instructions

  1. Run this updated cherry picking script locally and ensure it doesn't error before cherry picking PRs
  2. Make sure this hasn't introduced a linting error.

Screenshots or screencast

Before After
Screen Shot 2022-10-12 at 3 04 58 pm Screen Shot 2022-10-12 at 3 52 04 pm

@aaronrobertshaw aaronrobertshaw added [Type] Bug An existing feature does not function as intended Developer Experience Ideas about improving block and theme developer experience Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) labels Oct 12, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Oct 12, 2022
talldan
talldan approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Mamaduka
Mamaduka approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, @aaronrobertshaw 🙇

@aaronrobertshaw
Copy link
Contributor Author

Thanks for catching this, @aaronrobertshaw 🙇

I may have hit the problem but @talldan's sleuthing made it a quick fix 🙂

@talldan talldan merged commit 500d50c into trunk Oct 12, 2022
@talldan talldan deleted the fix/automated-cherry-picking-script-sha-retrieval branch October 12, 2022 06:45
@github-actions github-actions bot added this to the Gutenberg 14.4 milestone Oct 12, 2022
@aaronrobertshaw aaronrobertshaw removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Oct 12, 2022
aaronrobertshaw added a commit that referenced this pull request Oct 12, 2022
@aaronrobertshaw
Restore retrieval of merge_commit_sha (#44890)
4d9858b
@aaronrobertshaw
Copy link
Contributor Author

I just cherry-picked this PR to the release/14.3 branch to get it included in the next release: 4d9858b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@Mamaduka Mamaduka Mamaduka approved these changes

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
Developer Experience Ideas about improving block and theme developer experience [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 14.4
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronrobertshaw @Mamaduka @talldan