Style Engine: move PHP unit tests to Gutenberg #44722
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAS?
Greetings humans!
This PR moves style engine PHP unit tests to Gutenberg
/phpunit
directory and adds 'Gutenberg' and 'gutenberg' prefixes/suffixes.I thought about adding a build step to copy/search/replace the tests, thereby keeping the PHP unit tests in the package folder, but decided against it because:
WARUM?
After 6.1, the style engine classes and methods are in Core.
Moving the tests and using the Gutenberg functions and classes allows us to continue development and avoid class collisions.
This PR also proposes to add a bash script to make Core backporting more easy.
The script and
.gitignore
files are optional and are only there to spark discussion. I'm thinking we shouldn't commit them.WIE?
Manually relocating files and adding
_Gutenberg
class andgutenberg_
function suffixes/prefixes.Testing Instructions
Lint and run all the tests!!
Or run a single test using the test class name!!
Example: