Cover: Fix erroneous focus style in editor. #44707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Bless you, this has been bothering me a lot lately! |
mtias
approved these changes
Oct 5, 2022
|
Size Change: +27 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
Cool, this is a really tiny one, which really should not affect the editor negatively at all, and doesn't touch the frontend. So I'll land it when the checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the editor, the focus style for the cover block is wrong, showing a gap at the bottom:
This PR fixes that gap, by unsetting a min-height applied to the focus style in the editor:
As best I can tell from context in style.scss, that min-height exists solely for the frontend, and to fix an older IE issue at that. This PR keeps that hack intact, but adds a comment explaining the context.
Testing Instructions
Test the cover block in the editor, and observe no gap between image and focus style bottom border.