Add missing value to CSS font-display descriptor in theme.json #44622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagelab
changed the title
carolinan
approved these changes
Oct 3, 2022
|
Thank you for this PR! |
aristath
added a commit
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The “optional” value for the CSS
font-displaydescriptor is missing fromtheme.json(see below). This PR simply adds it.Why?
The value is part of the CSS fonts spec, and it's recommended for body text, where a custom font is not absolutely required to load on the first visit and can be safely seen only on subsequent page loads.
How?
The
theme.jsonschema was manually updated with the missing value.Testing Instructions
theme.jsonfile, from any block theme, on VS Code.fontFamiliessection and add afontDisplaydefinition.font-faceproperty.