Navigation block: Add padding to buttons when Submenus Open on click is enabled #44605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Block] Navigation
|
Size Change: +89 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Nice catch, this looks good to me. I'd love a sanity check by @tellthemachines as she's worked on the button controls.
And related to that, instead of 4 rules, could we keep it at two rules by removing the a? I.e.
:where(.wp-block-navigation .wp-block-navigation__submenu-container .wp-block-navigation-submenu :not(.wp-element-button))?
|
I tried but the result was two different submenu sizes. |
|
I'm happy to try this. It's not a lot of code and it can be reverted if need be. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds padding to the submenu block and page list submenus when buttons are used instead of links.
-Buttons are used when the option "Submenus Open on click" is enabled.
Partial for #44591
This PR does not address the part where the page list submenus can not be opened.
Why?
The padding was only applied to links, so when the buttons were in use the spacing was incorrect.
How?
Updates the stylesheet to apply padding to the buttons in the submenu block and in the page list submenu.
Testing Instructions
Screenshots or screencast
Before:
After:
