Try running PHP unit tests in multiple PHP versions on github #44566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
the
[Type] Automated Testing
…iable in run command
It looks like this is because there's no 8.2 version of the WordPress image on docker hub - https://hub.docker.com/_/wordpress |
talldan
commented
Sep 29, 2022
Comment on lines
-73
to
-76
| - name: Install WordPress | ||
| run: | | ||
| npm run wp-env start | ||
|
|
There was a problem hiding this comment.
npm run test:unit:php already calls npm run wp-env start, so this is duplication.
There was a problem hiding this comment.
Oh, but lint:php which runs after this doesn't call npm run wp-env start. I've pushed a commit so that it does.
I personally think it might be better to go the other way and avoid npm run wp-env start as a prerequisite for these jobs.
|
Size Change: +36 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
The tests definitely run on PHP 8.1 now as expected, as there are some additional errors coming through: However the job for PHP 7.2 ends up being canceled: Not sure why 🤔 |
12 tasks
Well, the official Docker image from WP itself does have PHP 8.2 available: https://github.com/WordPress/wpdev-docker-images / https://hub.docker.com/u/wordpressdevelop |
|
Closing in favor of #46510 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #43333
wp-env supports specifying the PHP version as an environment variable, so I'm hoping this is all that's required to run PHP unit tests against multiple PHP versions.
Why?
It'll help catch issues like this one - PHP 8.2 | Gutenberg is introducing deprecated callables into WP Core.
One problem is that wp-env doesn't seem to support PHP 8.2, when I tried it from the command line it errors:
How?
Use a matrix for the 'unit-php' job. At the moment I've started with 7.2 and 8.1 as the PHP versions to test that this works.