-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServerSideRender: add new skipBlockSupportAttributes
prop
#44491
Merged
Merged
Changes from 11 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
3b35e88
ServerSideRender: add new `skipBlockSupportAttributes` prop
t-hamano 2b6ec9a
Update readme
t-hamano 43fde25
update changelog
t-hamano 59a6178
add unit test
t-hamano b70814f
Fix typo
t-hamano 8791cc3
Don't remove attributes and styles which serialization is omitted
t-hamano 05ab652
Merge branch 'trunk' into enhancement/server-side-render-global-styles
t-hamano a42b10e
Update unit tests
t-hamano f1b0670
Update readme
t-hamano 04f3af0
Don't remove custom style
t-hamano abf2d7e
Support color.link and update tests
t-hamano e027d44
Update function docs
t-hamano d9600d6
Revert "Update function docs"
t-hamano 1a7fd7c
Revert "Support color.link and update tests"
t-hamano 43910b2
Revert "Don't remove custom style"
t-hamano 5d811c8
Revert "Update readme"
t-hamano bd1ff1e
Revert "Update unit tests"
t-hamano aa507a1
Revert "Don't remove attributes and styles which serialization is omi…
t-hamano 452c11d
Merge branch 'trunk' into enhancement/server-side-render-global-styles
t-hamano 7b02d8d
Don't pass className
t-hamano 4be4688
Update unit test
t-hamano ce8937a
Update readme
t-hamano d58e60c
Update readme
t-hamano 60e711d
Fix conflicts
t-hamano 0de5c1f
Revert unexpected changes
t-hamano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -0,0 +1,81 @@ | ||||
export const ATTRIBUTE_PROPERTY = { | ||||
textColor: [ 'color', 'text' ], | ||||
backgroundColor: [ 'color', 'background' ], | ||||
gradient: [ 'color', 'gradients' ], | ||||
fontSize: [ 'typography', 'fontSize' ], | ||||
fontFamily: [ 'typography', '__experimentalFontFamily' ], | ||||
borderColor: [ '__experimentalBorder', 'color' ], | ||||
}; | ||||
|
||||
export const STYLE_PROPERTY = { | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This definition is based on the following:
|
||||
color: { | ||||
text: { | ||||
support: [ 'color', 'text' ], | ||||
}, | ||||
background: { | ||||
support: [ 'color', 'background' ], | ||||
}, | ||||
gradient: { | ||||
support: [ 'color', 'gradients' ], | ||||
}, | ||||
}, | ||||
elements: { | ||||
link: { | ||||
support: [ 'color', 'link' ], | ||||
}, | ||||
}, | ||||
typography: { | ||||
fontSize: { | ||||
support: [ 'typography', 'fontSize' ], | ||||
}, | ||||
fontWeight: { | ||||
support: [ 'typography', '__experimentalFontWeight' ], | ||||
}, | ||||
fontStyle: { | ||||
support: [ 'typography', '__experimentalFontStyle' ], | ||||
}, | ||||
textTransform: { | ||||
support: [ 'typography', '__experimentalTextTransform' ], | ||||
}, | ||||
leterSpacing: { | ||||
support: [ 'typography', '__experimentalLetterSpacing' ], | ||||
}, | ||||
textDecoration: { | ||||
support: [ 'typography', '__experimentalTextDecoration' ], | ||||
}, | ||||
}, | ||||
spacing: { | ||||
margin: { | ||||
support: [ 'spacing', 'margin' ], | ||||
}, | ||||
padding: { | ||||
support: [ 'spacing', 'padding' ], | ||||
}, | ||||
blockGap: { | ||||
support: [ 'spacing', 'blockGap' ], | ||||
}, | ||||
}, | ||||
border: { | ||||
radius: { | ||||
support: [ '__experimentalBorder', 'radius' ], | ||||
subProperties: [ | ||||
'topLeft', | ||||
'topRight', | ||||
'bottomRight', | ||||
'bottomLeft', | ||||
], | ||||
}, | ||||
color: { | ||||
support: [ '__experimentalBorder', 'color' ], | ||||
additionalProperties: [ 'top', 'right', 'bottom', 'left' ], | ||||
}, | ||||
style: { | ||||
support: [ '__experimentalBorder', 'style' ], | ||||
additionalProperties: [ 'top', 'right', 'bottom', 'left' ], | ||||
}, | ||||
width: { | ||||
support: [ '__experimentalBorder', 'width' ], | ||||
additionalProperties: [ 'top', 'right', 'bottom', 'left' ], | ||||
}, | ||||
}, | ||||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the description is unnatural, please feel free to update it 🙏