Meta Boxes: Allow collapsing/sorting the meta boxes panels #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Feature] Meta Boxes
aduth
approved these changes
Jan 16, 2018
editor/store/effects.js
Outdated
| @@ -452,4 +452,10 @@ export default { | |||
| const message = spokenMessage || content; | |||
| speak( message, 'assertive' ); | |||
| }, | |||
| INITIALIZE_META_BOX_STATE( action ) { | |||
| // Allow toggeling metaboxes panels | |||
editor/store/effects.js
Outdated
| @@ -452,4 +452,10 @@ export default { | |||
| const message = spokenMessage || content; | |||
| speak( message, 'assertive' ); | |||
| }, | |||
| INITIALIZE_META_BOX_STATE( action ) { | |||
| // Allow toggeling metaboxes panels | |||
| if ( some( action.metaBoxes ) ) { | |||
There was a problem hiding this comment.
Minor: some is reasonable enough; isEmpty is maybe a bit more accurate to what you're testing, particularly since you're not providing a predicate for some.
There was a problem hiding this comment.
Actually, isEmpty doesn't work here because it's an object like this { side: true, normal: false }. isEmpty always returns false in this case.
2 tasks
youknowriad
force-pushed
the
fix/metaboxes-collapsing-sorting
branch
from
9d060bf to
b47bc41
Compare
2 tasks
|
I merged this PR into my development system and all the problems I mentioned in #4532 have been resolved. |
|
Travis is down for a long time now, I'm going to merge. Unit tests pass locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the meta boxes collapsing/sorting behavior we have in the classic editor.
It's as simple as calling
window.postboxes.add_postbox_toggles( 'post' );when we load the meta boxes.Testing instructions