Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes whitespace from l18n-strings #44314

Merged

Conversation

kebbet
Copy link
Contributor

@kebbet kebbet commented Sep 21, 2022

What?

This PR removes whitespaces from l18n-strings and closes #44312

Why?

Whitespaces should not be included before the actual string.

How?

Testing Instructions

Screenshots or screencast

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kebbet

@Mamaduka Mamaduka added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Sep 21, 2022
@Mamaduka Mamaduka merged commit db0b05a into WordPress:trunk Sep 21, 2022
@github-actions github-actions bot added this to the Gutenberg 14.2 milestone Sep 21, 2022
@kebbet kebbet deleted the GB44312---Removes-flanking-whitespaces branch September 21, 2022 07:56
@gziolo gziolo added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Sep 28, 2022
@gziolo
Copy link
Member

gziolo commented Sep 28, 2022

This change needs to be also applied directly in WordPress core's trunk.

@ockham
Copy link
Contributor

ockham commented Sep 28, 2022

This change needs to be also applied directly in WordPress core's trunk.

WordPress/wordpress-develop#3358

pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Sep 29, 2022
Merges [WordPress/gutenberg#44314 Gutenberg PR #44314] into trunk.

Follow-up to [54263] and [54269].

Props kebbet, bernhard-reiter.
See #56467.

git-svn-id: https://develop.svn.wordpress.org/trunk@54356 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Sep 29, 2022
Merges [WordPress/gutenberg#44314 Gutenberg PR #44314] into trunk.

Follow-up to [54263] and [54269].

Props kebbet, bernhard-reiter.
See #56467.
Built from https://develop.svn.wordpress.org/trunk@54356


git-svn-id: http://core.svn.wordpress.org/trunk@53915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Sep 29, 2022
Merges [WordPress/gutenberg#44314 Gutenberg PR #44314] into trunk.

Follow-up to [54263] and [54269].

Props kebbet, bernhard-reiter.
See #56467.
Built from https://develop.svn.wordpress.org/trunk@54356


git-svn-id: https://core.svn.wordpress.org/trunk@53915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@michalczaplinski michalczaplinski removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 3, 2022
ootwch pushed a commit to ootwch/wordpress-develop that referenced this pull request Nov 4, 2022
Merges [WordPress/gutenberg#44314 Gutenberg PR #44314] into trunk.

Follow-up to [54263] and [54269].

Props kebbet, bernhard-reiter.
See #56467.

git-svn-id: https://develop.svn.wordpress.org/trunk@54356 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

WP 6.1 alpha - Flanking whitespace in l18n strings
5 participants