Enforce coding guideline regarding the usage of quotation marks. #44305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…replace straight quotation marks.
pagelab
requested review from
michalczaplinski and
ajitbohra
as code owners
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @pagelab! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
pagelab
requested review from
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
michalczaplinski
added
the
[Type] Code Quality
michalczaplinski
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates text strings that don’t follow the coding guideline regarding the usage of the apostrophe instead of single-quote characters.
It also looks for double-quote characters (aka “straight quotes”) and replace then with appropriate “curly quotes”.
Why
Besides enforcing a coding guideline, this is a good opportunity to push for better typographic handling of text strings, as WordPress now focus more on design.
How
I just manually searched for instances of text strings that include single or double-quote characters and changed them accordingly where appropriate.
Several blocks already followed the guideline regarging the usage of the apostrophe, but there were many more that did not. Apostrophes or curly quotes are already used in user-facing messages in the following blocks:
The following blocks include user-facing messages that include straight quotation marks:
Testing Instructions
Add any of the above blocks in the site editor or post editor, and check user-facing messages for the use of the apostrophe or curly quotes.