Fix demo content cover block text color #44174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The external URL that the demo cover block uses causes FastAverageColor used in the is-dark/is-light heuristic to fail because of a tainted canvas due to a CORS error. Manually setting the text color for the demo is the most straightforward way to fix it right now.
jasmussen
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
That was easy. Nice!
To be clear, I can't actually test this, the demo content takes me to http://local-wordpress.local/wp-admin/gutenberg and doesn't show the content, but I'm fairly sure that's a vestige of me using Local instead of Docker. Code changes look good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the demo content cover block text color.
Why?
We want the content on our demo to look nice and be color accessible.
How?
The external URL that the demo cover block uses causes FastAverageColor used in the is-dark/is-light heuristic to fail because of a tainted canvas due to a CORS error. Manually setting the text color for the demo is the most straightforward way to fix it right now.
Testing Instructions
Screenshots or screencast
Before
After