Migrate columns test case to Playwright #43964
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @alvitazwar! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
github-actions
bot
added
the
First-time Contributor
skorasaurus
added
the
[Type] Automated Testing
|
@kevin940726 Can you please review this PR? |
|
Thanks for contributing, @alvitazwar! While Playwright migration looks mostly good, I don't think it's testing the same case as the old test. The previous tests confirm that Block Inserter only displays allowed blocks for the Columns. Screenshot
|
|
@Mamaduka |
There was a problem hiding this comment.
Thanks, @alvitazwar!
I left some notes. Let me know if you have any questions regarding them.
Mamaduka
removed
the
First-time Contributor
|
@alvitazwar, I noticed that the tests also cause lint errors. We should fix that before we can merge. |
Mamaduka
changed the title
|
@Mamaduka I addressed your feedbacks and fix lint errors please check now |
|
@Mamaduka thanks for the support. Really thanks a lot |
What?
Based on #38570, part of #38851. Migrate columns.test.js to its Playwright counterpart.
Why?
See #38570 for its background and rationale.
This is split into a new PR for easier review.
How?
See #38570 for the proposed migration steps.
Testing Instructions
npm run test:e2e:playwright /test/e2e/specs/editor/blocks/columns.spec.js
Screencast
Screen.Recording.2022-09-30.at.3.41.41.PM.mov