Layout: Fix undefined index notice when attempting to check layout type #43756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
Thanks @andrewserong ! 🎉 Backported to the 14.0 branch in b8b6edb ✅ |
priethor
removed
the
Backport to Gutenberg Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue introduced in: #43689
Add an additional
isset()check before checking the layout type inlayout.phpto prevent a PHP notice about an undefined indexWhy?
For blocks that don't have a type set, an undefined index notice is currently being output when rendering a post or page
How?
Add an additional
isset()check to prevent the notice from being outputTesting Instructions
With TwentyTwentyTwo theme, go to view the site, and the PHP notices should not appear in
debug.logwith this PR applied.Ensure that the fix from #43689 still appears to be working correctly.
Screenshots or screencast
Before, I was seeing lots of the following notice:
After, the notice should no longer be output.