-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make inline toolbar navigable by arrow keys #43645
Make inline toolbar navigable by arrow keys #43645
Conversation
I will follow up on these failing tests next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apmatthews Thanks for the improvements. Could you please refresh the branch and maybe tests will pass?
@apmatthews Maybe try one more refresh? Lots seems to be changing around this at the moment. |
@alexstine I've just kicked it off once more. If tests do not pass this time, I'll try and find some time this week to pull it down and debug whatever is failing. The failures don't seem related at first glance, but who knows 🤷🏻. Thanks for bumping it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What?
Allows users to navigate the inline toolbar using arrow keys rather than tabs.
Why?
Users can navigate the block toolbar using arrow keys. The inline toolbar should behave the same way for consistency.
Resolves #43564
How?
Adds the
NavigableToolbar
component to the inline toolbar.Testing Instructions