Core Data: Add canRead to useResourcePermissions #43484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -146 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
gziolo
added
[Package] Core data
gziolo
changed the title
gziolo
approved these changes
Aug 23, 2022
| @@ -152,7 +172,7 @@ export default function useResourcePermissions< IdType = void >( | |||
|
|
|||
| export function __experimentalUseResourcePermissions( | |||
| resource: string, | |||
| id?: IdType | |||
| id?: unknown | |||
There was a problem hiding this comment.
Is that change necessary? The type of the stable method didn't change.
There was a problem hiding this comment.
The stable method has a generic IdType parameter while this one doesn't.
There was a problem hiding this comment.
I really need to learn more about TypeScript 🙈
Feel free to land this PR 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds
canReadproperty to theuseResourcePermissionshook. WordPress permissions involvecreate,update,delete, andreadactions, and that last one was missing.Testing Instructions
Confirm the tests are green
cc @gziolo @Mamaduka