Block Editor: Fix spinner position in URLInput component #43472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
jameskoster and
jasmussen
and removed request for
ellatrix
Mamaduka
added
[Type] Bug
|
Size Change: -41 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 22, 2022
| margin: 0; | ||
| top: calc(50% - #{$spinner-size} / 2); |
There was a problem hiding this comment.
I would love for us to be able to remove as much spinner-positioning code across the codebase as we can. That's not a specific comment on this piece, which looks good. Just a general thought: it'd be nice if the component itself had generic good positioning in 90% of the cases without any additions.
There was a problem hiding this comment.
That would be great. I copied this style from the Snipper component.
|
@jasmussen, the bug is currently specific to the Image block's "Insert link" control. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #37070.
PR fixes the spinner position inside the
URLInputcomponent and removes broken/unused styles.Testing Instructions
Screenshots or screencast
Before
After