CustomGradientPicker: use KeyboardEvent.code instead of KeyboardEvent.keyCode #43437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
changed the title
ciampo
added
[Type] Enhancement
tyxla
approved these changes
Aug 22, 2022
Co-authored-by: Marin Atanasov <[email protected]>
This was referenced Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor the
CustomGradientPickercomponent to rely oncodeinstead ofkeyCodefor keyboard eventsWhy?
keyCodeis deprecated, and replaced bycodeHow?
Easy swap of values
Testing Instructions
In Storybook, visit the gradient picker example, focus the gradient control points, and make sure that pressing arrow left/right actually moves the control points along the gradient bar.