Lodash: Remove _.omit() from deprecated blocks
#43411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
sgomes,
aristath,
gziolo,
swissspidy,
jorgefilipecosta,
chad1008,
ntsekouras and
fabiankaegy
tyxla
requested review from
tellthemachines,
geriux and
ajitbohra
as code owners
|
Size Change: -26 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
sgomes
requested changes
Aug 19, 2022
| ? attributes.backgroundColor | ||
| : undefined, | ||
| } ), | ||
| [ 'fontSize', 'textColor', 'backgroundColor', 'style' ] |
There was a problem hiding this comment.
I may be missing something, but it looks like your code isn't omitting these anymore?
There was a problem hiding this comment.
Thanks for double-checking - this is intentional. If you look at the original code, you'll notice that omit() is called with a single argument by mistake. The second argument was being passed to migrateCustomColorsAndFontSizes() and it just ignored it. So we never actually omitted them here and I preferred to keep the same behavior.
There was a problem hiding this comment.
Oh, you're right, the array is outside of the omit call! Missed that, sorry 👍
sgomes
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
_.omit()usage from all deprecated blocks.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
_.omit()is generally safe and easy to replace with object destructuring with spread and rest syntax. Changes are extremely straightforward and similar so I've decided to place them all in a single PR.Testing Instructions
Verify the older versions of these blocks still work well: