Testing: Update test fixture for performance test #43359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Performance
priethor
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
The performance comparison with trunk shows very similar results with the new tests, albeit with a slight degradation in some tests compared to trunk that is to be expected after adding the inner blocks.
However, other tests (first paint, loading) perform better than trunk, but I think the differences in all tests are so small that they fit into the typical divergences between test runs.
In any case, this PR would only surface performance degradations if they already exist in the new implementation of the Quote block, so let's ship it 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The Quote block is now using inner blocks to store content added previously as paragraphs. Let's also update the test fixture used with the performance tests to ensure they use the latest syntax for this block.
Why?
The block editor needs to update the block syntax for an old version of Quote blocks included in the Performance Tests. This might impact the final result as the editor needs to do some additional work.
How?
I opened the test content in the block editor and the transformation magically happened.
Testing Instructions
Check GitHub action with Performance Tests to see the difference: https://github.com/WordPress/gutenberg/runs/7894579368?check_suite_focus=true.