Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullquote: Add missing typography supports #43346

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography supports to the Pullquote block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing font-family, text-decoration typography support.

Testing Instructions

  1. Edit a post, add a Pullquote block, and select it.
  2. Check that the font-family & text-decoration controls are now available.
  3. Test various typography settings ensuring styles are applied in the editor.
  4. Save and confirm the application on the frontend.
  5. Switch to the site editor, selecting a template with the Pullquote block.
  6. Navigate to Global Styles > Blocks > Pullquote > Typography
  7. Test applying a new font-family and confirm its applied in the preview and on the frontend.

Screenshots or screencast

Screen.Recording.2022-08-18.at.12.13.26.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Pullquote Affects the Pullquote Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 18, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 18, 2022
Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well for me, was able to:
✅ apply typography settings to pull-quote block in editor and and changes showed in editor canvas and frontend
✅ Was able to change block typography settings in global styles and these were applied in editor and frontend

@aaronrobertshaw aaronrobertshaw merged commit 603013a into trunk Aug 19, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-supports-to-pullquote branch August 19, 2022 06:26
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 19, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pullquote Affects the Pullquote Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants