Embed: Update Reddit icon #43326
Merged
Embed: Update Reddit icon #43326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndiego
added
[Type] Enhancement
jasmussen
approved these changes
Aug 18, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the Reddit icon. This PR follows #43325.
Why?
The current Reddit icon is not consistent with Reddit brand guidelines. This icon gets us much closer while keeping the icon the same as in #43325. Interestingly some embed icons are colored, and some are not 🤔
I chose to keep this black, but I can update it to an orange circle with the icon inside. This would match the guidelines exactly. Either way, this update moves us in the right direction.
How?
Update the SVG in the Embed block.
Testing Instructions
Screenshots or screencast
Before:
After:
