[Block Library - Query Loop]: Honour intended post type when previewing patterns and when replacing with patterns #43285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
ntsekouras
requested review from
mcsf,
mtias,
gziolo,
jameskoster,
nerrad and
annezazu
|
Size Change: +160 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
From a design perspective my feeling is that the previews lose their effectiveness if they aren't accurate. It's still worth landing this as it fixes a bug, but it would be good to look into contextual previews soon after. |
ntsekouras
force-pushed
the
try/improve-query-loop-pattern-setup-flow
branch
from
564266c
to
6711308
Compare
ntsekouras
force-pushed
the
try/improve-query-loop-pattern-setup-flow
branch
from
6711308
to
ec6de9f
Compare
@jameskoster I made the previews based on the current post type as well. |
jameskoster
approved these changes
Aug 19, 2022
mcsf
approved these changes
Aug 19, 2022
ntsekouras
changed the title
ntsekouras
changed the title
20 tasks
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #42533
From the issue:
How?
This PR doesn't explore some generic solution(we might not even need one) as Query Loop is quite complex and I think it's okay to have some specific handling to accommodate this, and also become a lot more flexible and open to extension by third parties in the future.
In the pattern setup and replace flow, and the block variations(
scope) flow I'm updating the Query Loop blocks to be inserted by retaining the existingquery.postTypeandquery.inheritoptions. These two properties are fundamental for the expected functionality of the block and don't affect its design and presentation.What this means in practice is that if we have a Query Loop with
postType: productand choose toreplacewith another patterns(we want to update the design), thepostType and inheritproperties will be retained.Testing Instructions
Replace flow
postTypeto anything thanpost, as is the one used by most patterns.replacein block toolbar and select another patternpostType and inheritare retained.Scope block variations
page) to the Posts List (inserter) variation here.Posts Listblock and choosestart blank.postTypeis retainedScreenshots or screencast
Screen.Recording.2022-08-19.at.3.40.05.PM.mov