DuotonePicker/DuotoneSwatch: Add stories #43225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
ciampo
reviewed
Aug 16, 2022
| argTypes: { | ||
| clearable: { control: { type: 'boolean' } }, | ||
| onChange: { action: 'onChange' }, | ||
| unsetable: { control: { type: 'boolean' } }, |
There was a problem hiding this comment.
that's a curious propname, wonder why this was preferred over more standard prop names like readonly or disabled 🤔
There was a problem hiding this comment.
Apparently it's the prop that dictates whether to add this Unset option in the options:
ciampo
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds Storybook stories for DuotonePicker and DuotoneSwatch.
Why?
We're going to be doing some refactors on the color-related components, and these duotone components are missing basic stories.
Testing Instructions
npm run storybook:devand check stories for DuotonePicker and DuotoneSwatch.