Fix block toolbar offset in site editor when toggling sidebars #43172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
force-pushed
the
fix/block-toolbar-offset-when-toggling-sidebars
branch
from
8b2322b to
fe29e43
Compare
67 tasks
|
Size Change: +20 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Aug 12, 2022
talldan
force-pushed
the
fix/block-toolbar-offset-when-toggling-sidebars
branch
from
a884521 to
a3dba0d
Compare
|
It seems we missed this in site editor: Screen.Recording.2022-08-16.at.12.18.02.PM.movCheck on scroll what happens to the block popover.. |
I can also reproduce this. Should we revert and take another attempt at this fix? |
I think we should, yes.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #42770
Fixes a bug in the site editor, where the block toolbar would be offset incorrectly after inserting a block from the global inserter
Why?
In the site editor, part of the way popovers position themselves correctly is by offsetting their position against the editor canvas iframe.
When opening the inserter sidebar and inserting a block, the iframe is moved to the left to make space for the sidebar. The inserted block's toolbar iframe offset is calculated using this position that's shifted to the left.
When closing the sidebar, this offset isn't recalculated, as there's no
resizeevent listener.How?
Adds a resize event listener for the iframe offset.
Testing Instructions
Expected: the block's toolbar position should be correct (aligned to the left side of the block.
Screenshots or screencast
Before
Kapture.2022-08-12.at.17.00.01.mp4
After
Kapture.2022-08-12.at.16.58.05.mp4