Quote: fix raw transform handler #43093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
Thanks for the quick fix here — good reminder of something to keep an eye on when we open up other blocks for more flexible nested structures. |
|
Size Change: +35 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
fix/quote-raw-handling
branch
from
042173b to
9a70ce0
Compare
Mamaduka
approved these changes
Aug 9, 2022
|
Cherry-picked to the 13.8 branch and released in Gutenberg 13.8.2. ✅ |
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use the correct raw handler depending on the context.
Why?
Currently we're using the
rawHandler, which is letting too much markup through on paste.How?
We have two raw handlers: a default one (used for legacy context for example) and one for paste.
So far we didn't have the use case for nested raw handlers, so we never ran into this issue before.
We need to use the correct handler in the raw transform depending on which one is running. To solve that we can pass down the handler to the transform callback.
Testing Instructions
See integration test. Diff:
Screenshots or screencast