Revert "Add block variations for individual template parts" #42740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8d2e12d.
|
Can confirm that the mentioned PR is breaking the button element, and this revert fixes that. Thanks for finding this one out! |
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
|
I don't understand this. Why would the mentioned PR effect Theme JSON. All very strange. Perhaps @talldan would know as the PR's author? |
|
I have a fix here: #42748 |
It's very random. I wouldn't expect that from calling a getter function, as they should generally be side-effect free. I'm glad @scruffian found the fix as I probably never would have. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #42454
It seems like this recently merged PR is breaking several
theme.jsonfeatures working previously.I haven't tested this extensively but, for example, these features are no longer working:
After reverting the mentioned PR these functionalities work again as before, so I propose to revert it until further testing.