-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Site Editor]: Fix Reakit warning on creation template component #42392
Merged
Mamaduka
merged 1 commit into
trunk
from
fix/reakit-warning-in-site-editor-add-templates
Jul 13, 2022
Merged
[Site Editor]: Fix Reakit warning on creation template component #42392
Mamaduka
merged 1 commit into
trunk
from
fix/reakit-warning-in-site-editor-add-templates
Jul 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
label
Jul 13, 2022
Size Change: +15 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, and the warning is gone 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the warning coming from a missing
aria-label
in adding new templates in site editor