Fix tooltip appearing when opening popovers in Summary panel #42381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
|
Size Change: +5 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds
focusOnMountto all of the popovers in the Summary panel.Why?
The default behaviour is that the first focusable element receives focus. This isn't desirable for a popover that isn't a menu. Also, this was causing a tooltip to appear immediately after opening these popovers, which is distracting:
By setting
focusOnMount, the container receives focus, not the first focusable element:You can then press Tab to move focus to the first focusable element.
How?
Testing Instructions
Screenshots or screencast