Equalize modal content padding #42370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
|
Nice PR. Maybe the Cancel and Save dialog buttons could be more separated, as they appear to lack any spacing between them now (taking into account the Cancel button padding, separation seems to be 0px) |
javierarce
added
the
Needs Figma Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the padding on modal content so that the bottom matches left and right.
Why?
It is more visually appealing.
Testing Instructions
Open a modal an check that the bottom padding matches the left and right.
Screenshots or screencast