Fix list view drop indicator positioning #42353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
|
Fantastic, thanks for fixing this one up @talldan, glad it turned out to be a one-liner! |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #42058
After the recent popover component refactor, drop indicators in List View were misaligned, always seemingly being out by the height of one block.
Why?
The bug seems to be in the computation of the rectangle used to position the drop indicator. This is called the popover 'anchor' rectangle.
The rectangle should have a zero height because it has
topandbottomvalues that are always the same. But intrunkthe rectangle was always given the height of a block in List View (an impossible rectangle).Before the popover refactor, this incorrect
heightvalue must have been ignored, but after it seems the height is taken into account.That explains why the position is alway out by the height of one block.
How?
Change the height to
0.Testing Instructions
Screenshots or screencast
Before
Kapture.2022-07-12.at.16.51.58.mp4
After
Kapture.2022-07-12.at.16.50.03.mp4