Multi-selection: fix select all in Safari #42340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.02 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
bph
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In Safari, when the user selects all content with double cmd+a, rich text selection changes are triggered because Safari changes the range (from the blocks selected as a whole to selecting stuff inside the blocks). Internally this also causes the selection to change from full selection to partial selection.
How?
We need to avoid setting selection after select all unfortunately. This means that there's no longer a native selection to indicate the selection, so we fall back to the blue block boundaries.
Testing Instructions
Use Safari. Insert a quote with some text and a paragraph after that. Press cmd+a twice. Press delete. The quote remains with two paragraphs. It should be removed instead.
Since this is a Safari specific bug (different selectionchange events than Chrome), I can't add an e2e test.
Screenshots or screencast