-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix list wrap on second line #4229
Conversation
Thanks for looking into this @Rahmon. The code looks good to me and this doesn't seem to cause any regressions. Here's how it looks: cc. @karmatosed |
@@ -2,6 +2,5 @@ | |||
.blocks-list .blocks-editable__tinymce ul, | |||
.blocks-list .blocks-editable__tinymce ol { | |||
padding-left: 1.3em; | |||
list-style-position: inside; | |||
margin-left: 0; | |||
margin-left: 1.3em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the "inside" was added for some toolbar issues. cc @gziolo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added here: 1c53b02
Hi @Rahmon, thank you for your contribution 👍 The "list-style-position: inside;" was added as a fix to the bugs reported in #3727, #3707. This change does not create exactly the same bug, but affects the bullet point position creating a new undesirable behavior: |
I did some debugging and it looks like I found a workaround for the new spacing bug not involving list-style-position. So I think this problem is not a blocker and the changes can be merged and I can create a parallel PR that addresses this spacing bullet position problem. |
@jorgefilipecosta I saw that you did the last change in editor.scss file so I verified the bugs reported in #3727 and #3707 before submit this PR.. xD |
Description
Fix list wrap on second line. Fixes #4210
How Has This Been Tested?
This has been tested with "npm test", "npm run test-e2e" and manually on Chrome and Firefox.
Types of changes
Bug fix
Checklist: