Block Library: Remove client side variation fallbacks #42180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: -422 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
@ntsekouras, I think you worked with variation enhancers recently. Do you mind having a look at this PR? |
carolinan
approved these changes
Jul 7, 2022
|
Thank you, @carolinan ❤️ |
ntsekouras
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes client-side variation fallbacks for Navigation Link and Template Parts blocks.
Currently cannot fully remove "variation enhancers," since they handle the icon rendering. I think we can only use Dashicons when registering variations on the server side.
Why?
Like inline comments suggest the fallback was only needed while the Gutenberg plugin supported WP < 5.8.
Testing Instructions
Snippet