-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Author nicename template creation ability #42165
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
caf044b
Add: Author nicename template creation ability. Take 2
jorgefilipecosta 0d5a129
Refactor to include additional query params
jorgefilipecosta 014d9db
Update packages/edit-site/src/components/add-new-template/utils.js
jorgefilipecosta 388e1ff
Fix: Author-> Authors
jorgefilipecosta 02569c8
Applied feedback
jorgefilipecosta bbbb645
small tweaks
ntsekouras 7613062
Add author if it does not exists on defaults.
jorgefilipecosta 6e933ed
Add author unique id
jorgefilipecosta da474fe
small tweaks
ntsekouras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add the item here even if the
author
template doesn't exist in the default templates, like we do for the other entities.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied the feedback to be consistent with other entities, but I think as follow-up, we should not add a template even if it does not exist on default templates.
We are breaking backward compatibility. Currently a plugin can disable a template by removing it using the filter default_template_types in:
If we ignore the default code that currently removes a template will stop working because we add the template anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a tricky one we have to think better. When the filter was introduced though we didn't have this kind of functionality for adding more templates. We might need more feedback about what would be expected.
Another thing is that while this filter exists, users cannot actually add extra items, as they are filtered in js. The most obvious example would be the
home
template that already exists in this list but is filtered out in js..