Post Comments Form: Fix warning i18n #42131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
Internationalization (i18n)
ockham
commented
Jul 4, 2022
| @@ -86,7 +83,7 @@ export default function PostCommentsFormEdit( { | |||
| warning = sprintf( | |||
| /* translators: 1: Post type (i.e. "post", "page") */ | |||
| __( | |||
| 'Post Comments Form block: Comments for this post type (%s) are not enabled.' | |||
| 'Post Comments Form block: Comments are not enabled for this post type (%s).' | |||
There was a problem hiding this comment.
I changed the word order in this message to be more consistent with the updated per-item message.
ockham
commented
Jul 4, 2022
| ), | ||
| postType | ||
| warning = __( | ||
| 'Post Comments Form block: Comments are not enabled for this item.' |
There was a problem hiding this comment.
I used enabled rather than allowed to be more consistent with the button label and other messages.
There was a problem hiding this comment.
I also changed the word order a bit since Comments for this item are not enabled sounded a bit awkward to me.
|
Size Change: +2 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
cbravobernal
approved these changes
Jul 4, 2022
10 tasks
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: e5ace25 |
adamziel
pushed a commit
that referenced
this pull request
Jul 5, 2022
adamziel
added
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix an i18n issue with a warning message in the Post Comments Form block.
Why?
It was flagged in Slack the the previous message is problematic to translate into languages with grammatical gender.
How?
By changing the message to
Post Comments Form block: Comments are not enabled for this item.(Note that the message should really only refer to the current post or page (or CPT), not the entire post type, so it shouldn't read
Comments are not enabled for this post type: %s. We have separate logic for that.)Testing Instructions
Screenshots or screencast