Page Break Block: Remove duplicate block class #42121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
Size Change: -8 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #26054
Related: #42120
What?
This PR removes the duplicate block class (
wp-block-nextpage) in thecore/nextpageblock.Why?
In #26054, the block API has been updated to v2.
At that time, I suspect that the original block class may have remained.
How?
I removed a
divtag with a hardcoded block class insideuseBlockProps.Screenshots or screencast
I've compared them with the major themes, and the appearance does not change at all.