Add better ARIA labels to toggle buttons in Summary panel #42114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Enhancement
noisysocks
requested review from
javierarce,
Mamaduka,
talldan and
tellthemachines
|
Size Change: +791 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Jul 4, 2022
Comment on lines
12
to
+14
| export default function PostURLLabel() { | ||
| return usePostURLLabel(); | ||
| } |
There was a problem hiding this comment.
Should we remove this component? It's not used by core anymore.
There was a problem hiding this comment.
We can't without breaking backwards compatibility—it's exported from @wordpress/editor. I think it's fine to support both a component version and a hook version of these labels. It's a bit like how we have both withSelect and useSelect.
Mamaduka
approved these changes
Jul 4, 2022
alexstine
approved these changes
Jul 4, 2022
packages/edit-post/src/components/sidebar/post-visibility/index.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Stine <[email protected]>
|
Thanks @Mamaduka and @alexstine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the ARIA labels for the toggle buttons in Document Settings → Summary to be more descriptive of what the button does.
Why?
A screen reader currently reads the buttons like so:
I think this is pretty confusing as the first three labels do not describe what pressing the button actually does.
How?
This PR changes the labels so that they read:
Testing Instructions