Style engine: rename 'css_var' option property to 'convert_vars_to_classnames' #42113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR renames
css_var
toconvert_vars_to_classnames
.Why?
The style engine returns classnames in its output.
In the case of block supports, classnames are generated from
var:preset|{$css_property}|{$slug}
values and, in the resulting CSS, we skip generatingvar(--wp--preset--{$css_property}--{$slug})
.At the moment we have a
css_var
option to tell the style engine to compile CSS var values in CSS declarations.This should, however, be the default.
Block supports are the only places where we need to skip CSS vars and return corresponding classnames.
So instead, block supports can use the flag
convert_vars_to_classnames
instead of everywhere else usingcss_var
, which had a confusing name anyway.How?
Renaming
css_var
toconvert_vars_to_classnames
Testing Instructions
Run the tests!