Elements: Buttons: Style the cursor for all button elements #42102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
[Block] Search
|
Size Change: +23 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
I don't know if we should have this on button elements. |
|
Should we remove this from other elements then? |
|
I cite a few quotes from the linked article and add a few counterarguments below:
It's curious that despite the article citing Microsoft and Apple design guidelines, both companies' websites do heavy use of the The buttons of these cited websites seem to be very close to a canonical version of how a button looks and, despite that, they are using
Navigating the Apple website you could see other cases where no navigation elements, for example, slider menu toggles, are not following these guidelines either. The same goes for other mainstream websites on the internet: Facebook, Amazon, Twitter, Google, etc.
I tend to believe that the major companies on the internet set up more in-deep tests with real users than the article's author, and the results were in the direction of continuing using the pointer cursor. My conclusion: The usage and the perception of a feature can be very different from what a set of designers or standard authors thought at the time of building it. The meaning of words is not always what the dictionary established and I think the same happens with visual language. For these reasons, in my opinion, we should continue using the cursor pointer on buttons as we currently do with other WordPress button elements. |
matiasbenedetto
approved these changes
Jul 4, 2022
|
For now let's go with this for the sake of consistency and backwards compatibility. If we change it then at least we can update all buttons at once. |
This was referenced Jul 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds cursor: pointer to all button elements.
An alternative to #42099
Why?
So we can have consistent cursor rules for all button elements.
How?
Creates a new
elementsstylesheet in the block library package.Testing Instructions
Screenshots or screencast
I couldn't work out how to take screenshots while showing the cursor!